Hi Laurent, > -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Hi Sakari, > > Thank you for the patch. > > On Fri, Aug 04, 2023 at 01:52:26PM +0300, Sakari Ailus wrote: > > Improve the Kconfig help text to convey the ACE is for changing camera > > sensor ownership and CSI for configuring the CSI-2 rx and tx. > > > > Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > drivers/media/pci/intel/ivsc/Kconfig | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/pci/intel/ivsc/Kconfig > > b/drivers/media/pci/intel/ivsc/Kconfig > > index 9535ac10f4f7..e9d94dbb4305 100644 > > --- a/drivers/media/pci/intel/ivsc/Kconfig > > +++ b/drivers/media/pci/intel/ivsc/Kconfig > > @@ -8,5 +8,9 @@ config INTEL_VSC > > This adds support for Intel Visual Sensing Controller (IVSC). > > > > Enables the IVSC firmware services required for controlling > > - camera sensor ownership and CSI-2 link through Image Processing > > - Unit(IPU) driver of Intel. > > + camera sensor ownership between IVSC and host CPU (ACE) as well > > What does ACE stand for ? Below is from cover letter of my IVSC patch, hope that answer your question. """ Switching ownership requires an interface with two different hardware modules inside IVSC. The software interface to these modules is via Intel MEI (The Intel Management Engine) commands. These two hardware modules have two different MEI UUIDs to enumerate. These hardware modules are: - ACE (Algorithm Context Engine): This module is for algorithm computing when IVSC owns camera sensor. Also ACE module controls camera sensor's ownership. This hardware module is used to set ownership of camera sensor. - CSI (Camera Serial Interface): This module is used to route camera sensor data either to IVSC or to host for IPU driver and application. """ BR, Wentong > > > + as configuring the CSI-2 link (CSI) towards the Image Processing > > + Unit (IPU) driver of Intel. > > If I understand things correctly, this is about routing the data from the sensor to > the IVSC output towards the host. Is that right ? If so, let's make that explicit. > > > + > > + The modules will be called ivsc-csi and ivsc-ace. > > + > > -- > Regards, > > Laurent Pinchart
