On Wed, 24 May 2023 at 09:59, Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > > On 24/05/2023 09:48, Hans Verkuil wrote: > > On 13/04/2023 12:54, Martin Dørum wrote: > >> Platforms with qcom-camss use CSI-2, which means 1X16 is more correct > >> than 2X8. The fact that qcom-camss supported only 2X8 meant it was > >> incompatible with camera sensors it should have been compatible with. > >> > >> For example, the ov5645 driver (correctly) reports that its format is > >> UYVY8_1X16 (after ba449bb56203aedc4530a82b0f3f83358808b7f2). > >> Since qcom-camss only supports 2X8, the qcom-camss system is > >> incompatible with the ov5645 driver, even though they should be > >> compatible. > >> > >> This patch replaces all uses of UYVY8_2X8/VYUY8_2X8/YUYV8_2X8/YVYU8_2X8 > >> with the equivalent 1X16 formats. > >> > >> Signed-off-by: Martin Dørum <dorum@xxxxxxxxxxxxxxx <mailto:dorum@xxxxxxxxxxxxxxx>> > > Can one of the driver maintainers review this? > > > > It sounds reasonable, but I wonder if this can break existing setups where > > the sensor only supports 2X8 and not 1X16. > > > > Regards, > > > > Hans > > > > This hasn't hit my inbox but, I'll give it a test sometime this week. > > --- > bod This patch is fine. The only concern I had with upstream was drivers/media/i2c/ov5640 which is a default sensor on apq8016/db410c ov5640 looks fine. Please apply Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
