Il 03/08/23 11:53, Julien Stephan ha scritto:
On Mon, Jul 03, 2023 at 02:21:17PM +0200, AngeloGioacchino Del Regno wrote:
..snip..
+
+ mtk_cam_init_cfg(&cam->subdev, NULL);
mtk_cam_init_cfg() returns an integer, and this is probably because you expect
it to get logic to fail: in that case, check the result of that call here,
otherwise, make that function void.
Hi Angelo,
mtk_cam_init_cfg returns an int because it should match v4l2_subdev_pad_ops->init_cfg prototype..
mtk_cam_init does not fail, always return 0, so I though it would be ok
to discard the return value here. What do you think?
Right, I was thinking to make a void __mtk_cam_init_cfg(), but as an afterthought
it's just better to leave it as it is, let's go with your solution.
Cheers,
Angelo
+
..snip..
+ unsigned int bpp;
Can we get any format that uses a billion bits per pixel? :-P
u8 bpp;
I am preparing the driver for futur upgrades.. in a billion years ;)
Cheers
Julien
