> -----Original Message----- > From: Laurent Pinchart [mailto:laurent.pinchart@xxxxxxxxxxxxxxxx] > Sent: Wednesday, October 06, 2010 3:43 PM > To: Hiremath, Vaibhav > Cc: linux-media@xxxxxxxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH/RFC v3 03/11] v4l: Group media bus pixel codes by > types and sort them alphabetically > > Hi Vaibhav, > > On Wednesday 06 October 2010 11:19:21 Hiremath, Vaibhav wrote: > > On Tuesday, October 05, 2010 7:55 PM Laurent Pinchart wrote: > > > > > > Adding new pixel codes at the end of the enumeration will soon create > a > > > mess, so group the pixel codes by type and sort them by bus_width, > bits > > > per component, samples per pixel and order of subsamples. > > > > > > As the codes are part of the kernel ABI their value can't change when > a > > > new code is inserted in the enumeration, so they are given an explicit > > > numerical value. When inserting a new pixel code developers must use > and > > > update the next free value. > > > > [snip] > > > > + V4L2_MBUS_FMT_FIXED = 0x0001, > > > + > > > + /* RGB - next is 0x1005 */ > > > > Don't you think adding "next is 0x" is not required? > > Also while adding to this list someone has to modify here too. > > > > Same applies to all such places. > > The idea is that formats will be ordered by name. When adding new formats, > the > numerical values will then become out of order. Keeping a comment with the > next format value will avoid having to search through the enum for the > last > used value. [Hiremath, Vaibhav] I understand your point, but still I think you have defined the format structure very well and should be very easy to understand that's it is following some protocol. Thanks, Vaibhav > > > > + V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE = 0x1001, > > > + V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE = 0x1002, > > > + V4L2_MBUS_FMT_RGB565_2X8_BE = 0x1003, > > > + V4L2_MBUS_FMT_RGB565_2X8_LE = 0x1004, > > > + > > > + /* YUV (including grey) - next is 0x200b */ > > > + V4L2_MBUS_FMT_Y8_1X8 = 0x2001, > > > + V4L2_MBUS_FMT_UYVY8_1_5X8 = 0x2002, > > > + V4L2_MBUS_FMT_VYUY8_1_5X8 = 0x2003, > > > + V4L2_MBUS_FMT_YUYV8_1_5X8 = 0x2004, > > > + V4L2_MBUS_FMT_YVYU8_1_5X8 = 0x2005, > > > + V4L2_MBUS_FMT_UYVY8_2X8 = 0x2006, > > > + V4L2_MBUS_FMT_VYUY8_2X8 = 0x2007, > > > + V4L2_MBUS_FMT_YUYV8_2X8 = 0x2008, > > > + V4L2_MBUS_FMT_YVYU8_2X8 = 0x2009, > > > + V4L2_MBUS_FMT_Y10_1X10 = 0x200a, > > > + > > > + /* Bayer - next is 0x3009 */ > > > + V4L2_MBUS_FMT_SBGGR8_1X8 = 0x3001, > > > + V4L2_MBUS_FMT_SGRBG8_1X8 = 0x3002, > > > + V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE = 0x3003, > > > + V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE = 0x3004, > > > + V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE = 0x3005, > > > + V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE = 0x3006, > > > + V4L2_MBUS_FMT_SBGGR10_1X10 = 0x3007, > > > + V4L2_MBUS_FMT_SBGGR12_1X12 = 0x3008, > > -- > Regards, > > Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
