Hi Sakari, On 01/08/2023 09:14, Sakari Ailus wrote: > Hi folks, > > These two little patches address a couple of compiler and smatch warnings. > > Sakari Ailus (2): > media: ccs-pll: Initialise best_div to avoid a compiler warning > media: pci: ipu3-cio2: Initialise timing struct to avoid a compiler > warning > > drivers/media/i2c/ccs-pll.c | 2 +- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Much appreciated! I've merged these two patches. I'm left with one more ccs smatch warning in the daily build: drivers/media/i2c/ccs/ccs-data.c:524 ccs_data_parse_rules() warn: address of NULL pointer 'rules' While 'rules' shouldn't be NULL, it is too difficult for smatch (or me, for that matter) to see that. And I am also wondering if a NULL check wouldn't make the code more robust in case of broken rules. Regards, Hans
