[sailus-media-tree:master 40/41] drivers/media/pci/intel/ivsc/mei_csi.c:574:40: warning: 'struct v4l2_async_subdev' declared inside parameter list will not be visible outside of this definition or declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://linuxtv.org/sailus/media_tree.git master
head:   f6a458a2c82c225125c937cfd5675c2a3c494b33
commit: cc561f8b16e6ce155c6368eb6bb3497f3d51332b [40/41] media: pci: intel: ivsc: Add CSI submodule
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230731/202307312307.t1gJlUux-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230731/202307312307.t1gJlUux-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307312307.t1gJlUux-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/media/pci/intel/ivsc/mei_csi.c:574:40: warning: 'struct v4l2_async_subdev' declared inside parameter list will not be visible outside of this definition or declaration
     574 |                                 struct v4l2_async_subdev *asd)
         |                                        ^~~~~~~~~~~~~~~~~
   drivers/media/pci/intel/ivsc/mei_csi.c: In function 'mei_csi_notify_bound':
   drivers/media/pci/intel/ivsc/mei_csi.c:579:63: error: invalid use of undefined type 'struct v4l2_async_subdev'
     579 |         pad = media_entity_get_fwnode_pad(&subdev->entity, asd->match.fwnode,
         |                                                               ^~
   drivers/media/pci/intel/ivsc/mei_csi.c: At top level:
   drivers/media/pci/intel/ivsc/mei_csi.c:595:42: warning: 'struct v4l2_async_subdev' declared inside parameter list will not be visible outside of this definition or declaration
     595 |                                   struct v4l2_async_subdev *asd)
         |                                          ^~~~~~~~~~~~~~~~~
   drivers/media/pci/intel/ivsc/mei_csi.c:603:18: error: initialization of 'int (*)(struct v4l2_async_notifier *, struct v4l2_subdev *, struct v4l2_async_connection *)' from incompatible pointer type 'int (*)(struct v4l2_async_notifier *, struct v4l2_subdev *, struct v4l2_async_subdev *)' [-Werror=incompatible-pointer-types]
     603 |         .bound = mei_csi_notify_bound,
         |                  ^~~~~~~~~~~~~~~~~~~~
   drivers/media/pci/intel/ivsc/mei_csi.c:603:18: note: (near initialization for 'mei_csi_notify_ops.bound')
   drivers/media/pci/intel/ivsc/mei_csi.c:604:19: error: initialization of 'void (*)(struct v4l2_async_notifier *, struct v4l2_subdev *, struct v4l2_async_connection *)' from incompatible pointer type 'void (*)(struct v4l2_async_notifier *, struct v4l2_subdev *, struct v4l2_async_subdev *)' [-Werror=incompatible-pointer-types]
     604 |         .unbind = mei_csi_notify_unbind,
         |                   ^~~~~~~~~~~~~~~~~~~~~
   drivers/media/pci/intel/ivsc/mei_csi.c:604:19: note: (near initialization for 'mei_csi_notify_ops.unbind')
   drivers/media/pci/intel/ivsc/mei_csi.c: In function 'mei_csi_parse_firmware':
   drivers/media/pci/intel/ivsc/mei_csi.c:669:9: error: too few arguments to function 'v4l2_async_nf_init'
     669 |         v4l2_async_nf_init(&csi->notifier);
         |         ^~~~~~~~~~~~~~~~~~
   In file included from drivers/media/pci/intel/ivsc/mei_csi.c:28:
   include/media/v4l2-async.h:159:6: note: declared here
     159 | void v4l2_async_nf_init(struct v4l2_async_notifier *notifier,
         |      ^~~~~~~~~~~~~~~~~~
   drivers/media/pci/intel/ivsc/mei_csi.c:673:40: error: invalid application of 'sizeof' to incomplete type 'struct v4l2_async_subdev'
     673 |                                        struct v4l2_async_subdev);
         |                                        ^~~~~~
   include/media/v4l2-async.h:196:70: note: in definition of macro 'v4l2_async_nf_add_fwnode'
     196 |         ((type *)__v4l2_async_nf_add_fwnode(notifier, fwnode, sizeof(type)))
         |                                                                      ^~~~
   drivers/media/pci/intel/ivsc/mei_csi.c:685:15: error: implicit declaration of function 'v4l2_async_subdev_nf_register'; did you mean 'v4l2_async_subdev_nf_init'? [-Werror=implicit-function-declaration]
     685 |         ret = v4l2_async_subdev_nf_register(&csi->subdev, &csi->notifier);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |               v4l2_async_subdev_nf_init
   cc1: some warnings being treated as errors


vim +574 drivers/media/pci/intel/ivsc/mei_csi.c

   571	
   572	static int mei_csi_notify_bound(struct v4l2_async_notifier *notifier,
   573					struct v4l2_subdev *subdev,
 > 574					struct v4l2_async_subdev *asd)
   575	{
   576		struct mei_csi *csi = notifier_to_csi(notifier);
   577		int pad;
   578	
   579		pad = media_entity_get_fwnode_pad(&subdev->entity, asd->match.fwnode,
   580						  MEDIA_PAD_FL_SOURCE);
   581		if (pad < 0)
   582			return pad;
   583	
   584		csi->remote = subdev;
   585		csi->remote_pad = pad;
   586	
   587		return media_create_pad_link(&subdev->entity, pad,
   588					     &csi->subdev.entity, 1,
   589					     MEDIA_LNK_FL_ENABLED |
   590					     MEDIA_LNK_FL_IMMUTABLE);
   591	}
   592	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux