Hi Jacopo,
Thank you for the patch.
On Mon, Jul 10, 2023 at 05:51:59PM +0200, Jacopo Mondi wrote:
> Complete the default format initialization in init_cfg() filling in
> the fields for the colorspace configuration copied from
> imx219_set_default_format().
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/imx219.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index 45b219321d98..cd43a897391c 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -714,6 +714,12 @@ static int imx219_init_cfg(struct v4l2_subdev *sd,
> format->code = imx219_get_format_code(imx219,
> MEDIA_BUS_FMT_SRGGB10_1X10);
> format->field = V4L2_FIELD_NONE;
> + format->colorspace = V4L2_COLORSPACE_SRGB;
> + format->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(format->colorspace);
> + format->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true,
> + format->colorspace,
> + format->ycbcr_enc);
> + format->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(format->colorspace);
There are multiple ways to initialize color space, and for raw sensors I
think I'd have a preference for being explicit:
format->colorspace = V4L2_COLORSPACE_SRGB;
format->ycbcr_enc = V4L2_YCBCR_ENC_601;
format->quantization = V4L2_QUANTIZATION_FULL_RANGE;
format->xfer_func = V4L2_XFER_FUNC_NONE;
Furthermore, I think V4L2_COLORSPACE_RAW would be better.
Granted, this doesn't match imx219_set_default_format(), but you remove
that function later in the series.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> /* Initialize crop rectangle. */
> crop = v4l2_subdev_get_pad_crop(sd, state, 0);
--
Regards,
Laurent Pinchart
