On Fri, Jul 28, 2023 at 06:53:14PM +0530, Vikash Garodia wrote: > Here is the implementation of v4l2 wrapper functions for all > v4l2 IOCTLs. > > Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> > Signed-off-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> In patch 2 you got this right, where the first Signed-off-by is that of the author (defined by a From:), in the rest you should up as the author, but Dikshita was the first one certifying the origin of this code. I suspect you need a Co-developed-by: Dikshita throughout the series? Your subject should include the subsystem prefix (media: ), it's not clear from the presented description if the "vidc" string adds value - are there other functionality under iris? For all the patches, do read: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes > --- > .../platform/qcom/iris/vidc/inc/msm_vidc_v4l2.h | 77 ++ > .../platform/qcom/iris/vidc/src/msm_vidc_v4l2.c | 953 +++++++++++++++++++++ > 2 files changed, 1030 insertions(+) > create mode 100644 drivers/media/platform/qcom/iris/vidc/inc/msm_vidc_v4l2.h > create mode 100644 drivers/media/platform/qcom/iris/vidc/src/msm_vidc_v4l2.c > > diff --git a/drivers/media/platform/qcom/iris/vidc/inc/msm_vidc_v4l2.h b/drivers/media/platform/qcom/iris/vidc/inc/msm_vidc_v4l2.h > new file mode 100644 > index 0000000..3766c9d > --- /dev/null > +++ b/drivers/media/platform/qcom/iris/vidc/inc/msm_vidc_v4l2.h > @@ -0,0 +1,77 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#ifndef _MSM_VIDC_V4L2_H_ > +#define _MSM_VIDC_V4L2_H_ > + > +#include <linux/fs.h> > +#include <linux/poll.h> > +#include <media/v4l2-ctrls.h> > +#include <media/v4l2-dev.h> > +#include <media/v4l2-ioctl.h> > + > +int msm_v4l2_open(struct file *filp); We already have a v4l2 driver for msm platforms. If it is concluded that there needs to be two (as was asked by others), then this isn't "the one and only MSM video codec/controller/c??? driver". This would be the qcom_iris_ driver, or something along those lines. All functions, variables, defines etc should be named accordingly. Regards, Bjorn
