Hi Kate, On 7/17/23 05:23, Kate Hsuan wrote: > Hi Hans. > > On Sun, Jul 16, 2023 at 1:09 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> isys_public.h is empty, remove it. >> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> .../hive_isp_css_include/host/isys_public.h | 19 ------------------- >> .../atomisp/pci/isp2400_input_system_public.h | 1 - >> 2 files changed, 20 deletions(-) >> delete mode 100644 drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_public.h >> >> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_public.h >> deleted file mode 100644 >> index 9dacef7a5cc1..000000000000 >> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_public.h >> +++ /dev/null >> @@ -1,19 +0,0 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> -/* >> - * Support for Intel Camera Imaging ISP subsystem. >> - * Copyright (c) 2015, Intel Corporation. >> - * >> - * This program is free software; you can redistribute it and/or modify it >> - * under the terms and conditions of the GNU General Public License, >> - * version 2, as published by the Free Software Foundation. >> - * >> - * This program is distributed in the hope it will be useful, but WITHOUT >> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> - * more details. >> - */ >> - >> -#ifndef __ISYS_PUBLIC_H_INCLUDED__ >> -#define __ISYS_PUBLIC_H_INCLUDED__ >> - >> -#endif /* __ISYS_PUBLIC_H_INCLUDED__ */ >> diff --git a/drivers/staging/media/atomisp/pci/isp2400_input_system_public.h b/drivers/staging/media/atomisp/pci/isp2400_input_system_public.h >> index 375c0db84b55..b1360eeb58df 100644 >> --- a/drivers/staging/media/atomisp/pci/isp2400_input_system_public.h >> +++ b/drivers/staging/media/atomisp/pci/isp2400_input_system_public.h >> @@ -17,7 +17,6 @@ >> #define __INPUT_SYSTEM_2400_PUBLIC_H_INCLUDED__ >> >> #include <type_support.h> >> -#include "isys_public.h" >> >> typedef struct receiver_state_s receiver_state_t; >> >> -- >> 2.41.0 >> > > Thank you for working on this. > > This file can be removed and it looks for me. > > Reviewed-by: Kate Hsuan <hpa@xxxxxxxxxx> Thank you for the reviews. I've pushed all 3 patches to my hansg/media-atomisp branch now. Regards, Hans
