Hi Alain,
Reviewed-By: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
On 7/21/23 14:03, Alain Volmat wrote:
> Cascade the s_stream call to the source subdev whenever the bridge
> streaming is enable / disabled.
>
> Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> ---
> v2: correct uninitialized ret variable in mipid02_stream_disable
>
> drivers/media/i2c/st-mipid02.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c
> index 906553a28676..ee456bd4cf76 100644
> --- a/drivers/media/i2c/st-mipid02.c
> +++ b/drivers/media/i2c/st-mipid02.c
> @@ -545,7 +545,14 @@ static int mipid02_configure_from_code(struct mipid02_dev *bridge)
> static int mipid02_stream_disable(struct mipid02_dev *bridge)
> {
> struct i2c_client *client = bridge->i2c_client;
> - int ret;
> + int ret = -EINVAL;
> +
> + if (!bridge->s_subdev)
> + goto error;
> +
> + ret = v4l2_subdev_call(bridge->s_subdev, video, s_stream, 0);
> + if (ret)
> + goto error;
>
> /* Disable all lanes */
> ret = mipid02_write_reg(bridge, MIPID02_CLK_LANE_REG1, 0);
> @@ -633,6 +640,10 @@ static int mipid02_stream_enable(struct mipid02_dev *bridge)
> if (ret)
> goto error;
>
> + ret = v4l2_subdev_call(bridge->s_subdev, video, s_stream, 1);
> + if (ret)
> + goto error;
> +
> return 0;
>
> error:
--
Regards,
Benjamin
