Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



July 18, 2023 at 1:14 AM, "Luben Tuikov" <luben.tuikov@xxxxxxx> wrote:
> > > Not sure about other drivers--they can speak for themselves and the CC list
> > >  should include them--please use "dim add-missing-cc" and make sure
> > >  that the Git commit description contains the Cc tags--then git send-email
> > >  will populate the SMTP CC. Feel free to add more Cc tags on top of that.
> >  
> >  I use `b4 prep -c` which I think does the same thing? I just ran it 
> >  again and it only added 'linaro-mm-sig@xxxxxxxxxxxxxxxx', not sure why 
> >  that one wasn't there. Am I missing anything else?
> 
> Not sure about "b4 prep -c"--using "git send-email" instead, but what is
> important is to add the Cc: tags as part of the commit message. A "git log" of
> drm-misc-next shows the proper format. Then maintainers add Link:
> tag to the correct email thread, which is usually completely automated
> by "dim" or by "git am", or both.

It's useful to note here that this is not standard practice across the entirety of the Linux tree. In general, Cc: trailers are added to individual commits when get_maintainer.pl wouldn't otherwise include someone in the recipient list. The "dim" tool mentioned here is specific to the DRM subsystem (the "d" stands for "DRM"). Since both tools work on git series, you can use it alongside b4.

DRM folks, if get_maintainer.pl isn't finding someone who should be included on a series of patches, should the MAINTAINERS file be updated to make it easier to submit valid patches without needing to know of "dim"?

Regards,
-K




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux