On 14/07/2023 03:50, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the Video Input Interface found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > --- > Changelog v2: Thank you for your patch. There is something to discuss/improve. > - no change > > Changelog v3: > - no change > > Changelog v4: > - fix style problems at the v3 patch > - remove "index" member > - update example > > Changelog v5: > - no change > > Changelog v6: > - add register definition of BUS-IF and MPU > > Changelog v7: > - remove trailing "bindings" from commit header message > - remove trailing "Device Tree Bindings" from title > - fix text wrapping of description > - change compatible to visconti5-viif Then the filename should be updated to match it: toshiba,visconti5-viif.yaml > - explicitly define allowed properties for port::endpoint > > .../bindings/media/toshiba,visconti-viif.yaml | 108 ++++++++++++++++++ > 1 file changed, 108 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > ... > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Input port, single endpoint describing the CSI-2 transmitter. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + additionalProperties: false This should be rather: unevaluatedProperties: false > + > + required: ["bus-type", "clock-noncontinuous", "link-frequencies", "remote-endpoint"] That's not the syntax we try to keep in the bindings. See renesas,rzg2l-csi2.yaml. > + > + properties: > + data-lanes: > + description: VIIF supports 2 or 4 data lanes > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 4 > + items: > + minimum: 1 > + maximum: 4 > + > + clock-lanes: > + description: VIIF supports 1 clock lane > + const: 0 Are you sure it must be on position 0? > + > + bus-type: true > + clock-noncontinuous: true > + link-frequencies: true > + remote-endpoint: true Drop all of these "xxx: true", should not be needed after converting to unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + viif@1c000000 { isp@ (or video or something else matching this type of the device, but this should be a generic name) > + compatible = "toshiba,visconti5-viif"; > + reg = <0 0x1c000000 0 0x6000>, > + <0 0x1c008000 0 0x400>, > + <0 0x1c00E000 0 0x1000>, > + <0 0x2417A000 0 0x1000>; Lowercase hex, please. Best regards, Krzysztof