Hi Jacopo,
Thank you for the patch.
On Tue, Jul 04, 2023 at 12:40:57PM +0200, Jacopo Mondi wrote:
> The imx219_set_pad_format() function adjusts the media bus code provided
> through the v4l2_subdev_format parameter to a media bus code known
> to be supported by the sensor.
>
> The same exact operation is performed by the imx219_get_format_code()
> function which called by imx219_update_pad_format(), which is in the
> imx219_set_pad_format() call path.
>
> Remove the duplicated operation and simplify imx219_set_pad_format().
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/imx219.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index c1246bd23b0d..37630e173040 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -754,19 +754,12 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
> int exposure_max, exposure_def, hblank;
> unsigned int i;
This variable should be dropped too.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> - for (i = 0; i < ARRAY_SIZE(imx219_mbus_formats); i++)
> - if (imx219_mbus_formats[i] == fmt->format.code)
> - break;
> - if (i >= ARRAY_SIZE(imx219_mbus_formats))
> - i = 0;
> -
> mode = v4l2_find_nearest_size(supported_modes,
> ARRAY_SIZE(supported_modes),
> width, height,
> fmt->format.width, fmt->format.height);
>
> - imx219_update_pad_format(imx219, mode, &fmt->format,
> - imx219_mbus_formats[i]);
> + imx219_update_pad_format(imx219, mode, &fmt->format, fmt->format.code);
>
> if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
> imx219->mode = mode;
--
Regards,
Laurent Pinchart
