On Tue, Sep 28, 2010 at 2:46 PM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxx> wrote:
> Instead of doing:
>
> [ 82.581639] tda18271 4-0060: creating new instance
> [ 82.588411] Unknown device detected @ 4-0060, device not supported.
> [ 82.594695] tda18271_attach: [4-0060|M] error -22 on line 1272
> [ 82.600530] tda18271 4-0060: destroying instance
>
> Print:
> [ 468.740392] Unknown device (0) detected @ 4-0060, device not supported.
>
> for the error message, to help detecting what's going wrong with the
> device.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
> diff --git a/drivers/media/common/tuners/tda18271-fe.c b/drivers/media/common/tuners/tda18271-fe.c
> index 7955e49..77e3642 100644
> --- a/drivers/media/common/tuners/tda18271-fe.c
> +++ b/drivers/media/common/tuners/tda18271-fe.c
> @@ -1177,7 +1177,7 @@ static int tda18271_get_id(struct dvb_frontend *fe)
> break;
> }
>
> - tda_info("%s detected @ %d-%04x%s\n", name,
> + tda_info("%s (%i) detected @ %d-%04x%s\n", name, regs[R_ID] & 0x7f,
> i2c_adapter_id(priv->i2c_props.adap),
> priv->i2c_props.addr,
> (0 == ret) ? "" : ", device not supported.");
A patch like this is fine for testing, but I see no reason for merging
this into the kernel. Can you provide an explaination as per why this
would be useful? In general, if you see, "Unknown device detected @
X-00YY, device not supported." then it means that this is not a
tda182x1.
Regards,
Mike Krufky
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
