Hi,
On 7/5/23 15:28, Sakari Ailus wrote:
> Hi Hans,
>
> On Wed, Jul 05, 2023 at 02:33:30PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 7/5/23 14:10, Sakari Ailus wrote:
>>> Hi Hans,
>>>
>>> On Wed, Jul 05, 2023 at 01:50:27PM +0200, Hans de Goede wrote:
>>>> Hi,
>>>>
>>>> On 7/5/23 13:38, Sakari Ailus wrote:
>>>>> Hi Hans,
>>>>>
>>>>> On Tue, Jul 04, 2023 at 12:59:53PM +0200, Hans de Goede wrote:
>>>>>> Hi Sakari,
>>>>>>
>>>>>> On 7/4/23 12:49, Sakari Ailus wrote:
>>>>>>> Hi Hans,
>>>>>>>
>>>>>>> On Fri, Jun 30, 2023 at 01:06:40PM +0200, Hans de Goede wrote:
>>>>>>>> The GalaxyCore GC0310 is used together with the atomisp no various
>>>>>>>> devices, add it to ipu_supported_sensors[].
>>>>>>>>
>>>>>>>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>>>>>>>> ---
>>>>>>>> drivers/media/pci/intel/ipu-bridge.c | 2 ++
>>>>>>>> 1 file changed, 2 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
>>>>>>>> index eb7c56e8ef9f..07a34f20af8e 100644
>>>>>>>> --- a/drivers/media/pci/intel/ipu-bridge.c
>>>>>>>> +++ b/drivers/media/pci/intel/ipu-bridge.c
>>>>>>>> @@ -36,6 +36,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = {
>>>>>>>> IPU_SENSOR_CONFIG("INT3537", 1, 437000000),
>>>>>>>> /* Omnivision ov13b10 */
>>>>>>>> IPU_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
>>>>>>>> + /* GalaxyCore GC0310 */
>>>>>>>> + IPU_SENSOR_CONFIG("INT0310", 0),
>>>>>>>
>>>>>>>
>>>>>>> Where is this HID from? A DSDT somewhere??
>>>>>>
>>>>>> This is used in many atomisp DSDTs on many atomisp devices,
>>>>>> see below for a quick grep to my no disk "database" of DSDTs.
>>>>>>
>>>>>> This is also already used by the existing gc0310 driver for
>>>>>> atomisp:
>>>>>>
>>>>>> https://git.linuxtv.org/media_stage.git/tree/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
>>>>>>
>>>>>> Note with the latest media_stage.git branch, which has
>>>>>> my "[GIT PULL] media: atomisp: Changes for 6.5-1" merged:
>>>>>>
>>>>>> https://lore.kernel.org/linux-media/4177be8a-7a77-c452-7b98-91d5e5af8e8b@xxxxxxxxxx/
>>>>>>
>>>>>> The gc0310 driver is now a fully standard v4l2 driver no longer using any
>>>>>> atomisp-isms / custom API. As such I have a patch pending to move
>>>>>> it to drivers/media/i2c :
>>>>>>
>>>>>> https://lore.kernel.org/linux-media/20230525190100.130010-6-hdegoede@xxxxxxxxxx/
>>>>>>
>>>>>> that patch is waiting for you to ack (or merge) it. Note if you chose to merge this
>>>>>> yourself, this should be applied on top of the latest media_stage/master
>>>>>> not on top of 6.4-rc1 .
>>>>>
>>>>> Ack, thanks for the info.
>>>>
>>>> Does this count as your Acked-by for the patch to mv gc0310.c to
>>>> drivers/media/i2c in my next media-atomisp pull-req ?
>>>>
>>>> or ... ?
>>>
>>> Can I take the set once others think it's good? I have Wentong's patch that
>>> goes on top.
>>
>> Yes you can and I'm expecting you to take this set, the question about if
>> your "Ack" as your Acked-by is about:
>>
>> https://lore.kernel.org/linux-media/20230525190100.130010-6-hdegoede@xxxxxxxxxx/
>>
>> which is not part of the set.
>>
>> I hope this helps clarify our little mis-communication which we seem to
>> be heaving here.
>
> Sorry, I somehow ignored this part of your original message.
>
> I'll review the set soon.
Thanks.
Note patches 1-4 of that set are already in media-staging. Only 5/5 is still
pending, I did not send that directly to Mauro because it touches files
outside driver/staging/media/atomisp.
Regards,
Hans
