Hi Laurent, On Sun, Jul 02, 2023 at 06:04:51PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Jun 30, 2023 at 05:03:54PM +0300, Sakari Ailus wrote: > > As selecting V4L2_FWNODE, MEDIA_CONTROLLER and VIDEO_V4L2_SUBDEV_API are > > now selected by the top level menu, they can be dropped from the > > individual drivers. Also dropped selectng V4L2_ASYNC for a single driver > > s/selectng/selecting/ I'll fix this for v2. > > > as this is already implied by V4L2_FWNODE. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > drivers/media/i2c/Kconfig | 149 ------------------------------- > > drivers/media/i2c/ccs/Kconfig | 3 - > > drivers/media/i2c/et8ek8/Kconfig | 3 - > > 3 files changed, 155 deletions(-) > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index c7ffaa79abeb..d8ea6be924c0 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -44,9 +44,6 @@ config VIDEO_CCS_PLL > > config VIDEO_AR0521 > > tristate "ON Semiconductor AR0521 sensor support" > > depends on I2C && VIDEO_DEV > > Should VIDEO_DEV also be moved to VIDEO_CAMERA_SENSOR ? Or, even better, > be dropped ? The I2C drivers shouldn't require it. > > And given that we're in the i2c/ directory, the I2C dependency should > also be moved to VIDEO_CAMERA_SENSOR. I wonder if we should then rename > it to VIDEO_I2C_CAMERA_SENSOR. Makes sense. CONFIG_RATIONAL is also needed by the ds90ub953 driver, I'll take this into account for v3. -- Regards, Sakari Ailus
