Hi, On 7/5/23 12:49, Sakari Ailus wrote: > Hi Andy, > > On Fri, Jun 30, 2023 at 08:46:49PM +0300, Andy Shevchenko wrote: >> On Fri, Jun 30, 2023 at 04:45:06PM +0300, Sakari Ailus wrote: >>> Switch to EXPORT_SYMBOL_NS_GPL() on ipu_bridge_instantiate_vcm(). The rest >>> of the ipu bridge symbols are this way already. >> >> Hmm... This actually changes the license, Why is it initially non-GPL and what >> are the consequences of this change? > > This does not change the license. It's just that the function will be > only available for GPL'd users. I'd think the reason why the plain > EXPORT_SYMBOL() is used is plainly historical. > > In any case, after Hans's set the other two functions required for using > the IPU bridge are GPL-only. Right I'll fix this in v3 of my series so that this symbol uses EXPORT_SYMBOL_NS_GPL() from the get go like the other 2 symbols. Regards, Hans