On Tue, Jul 04, 2023 at 01:20:33PM +0200, Hans de Goede wrote: > On 6/30/23 16:30, Andy Shevchenko wrote: > > On Fri, Jun 30, 2023 at 2:07 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >> > >> sensor->adev is no longer dereferenced before it is permanently set by: > >> > >> sensor->adev = acpi_dev_get(adev); > >> > >> So the early assignment with a borrowed reference can be dropped. > > > > Ah, now I see that that change was temporary. > > Ack > > > Can we avoid backporting > > it please? > > Patch 1/15 does fix a NULL pointer deref oops, so backporting it would > be a good thing to do IMHO. Then better to go with ACPI handle. I don't like the rewriting same field (even if it's the same information). It's prone to errors which might be hard to find. -- With Best Regards, Andy Shevchenko
