Hi,
On 6/30/23 16:08, Andy Shevchenko wrote:
> On Fri, Jun 30, 2023 at 2:07 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>>
>> After commit f54eb0ac7c1a ("media: ipu3-cio2: rename cio2 bridge to ipu
>> bridge and move out of ipu3") the ipu-bridge code is always builtin
>
> built in
>
>> even if all (its only) consumers are build as modules.
>
> I'm not sure I understood the remark in parentheses correctly. All of
> its consumers are the only consumers of this module?
There is only 1 consumer so both all of its consumers and its only
consumer, I'll drop the confusing "(its only)" part.
>
>> Fix this by turning "config IPU_BRIDGE" into a pure library Kconfig
>> option (not user selectable, must be selected by consumers) and
>> re-introducing the CIO2_BRIDGE Kconfig bits in .../pci/intel/ipu3/Kconfig
>> which were dropped to still allow building ipu3-cio2 without ipu-bridge
>> support.
>
> ...
>
>> config IPU_BRIDGE
>> - bool "Intel IPU Sensors Bridge"
>> - depends on VIDEO_IPU3_CIO2 && ACPI
>> - depends on I2C
>> - help
>> - This extension provides an API for the Intel IPU driver to create
>> - connections to cameras that are hidden in the SSDB buffer in ACPI.
>> - It can be used to enable support for cameras in detachable / hybrid
>> - devices that ship with Windows.
>> -
>> - Say Y here if your device is a detachable / hybrid laptop that comes
>> - with Windows installed by the OEM, for example:
>> -
>> - - Microsoft Surface models (except Surface Pro 3)
>> - - The Lenovo Miix line (for example the 510, 520, 710 and 720)
>> - - Dell 7285
>> -
>> - If in doubt, say N here.
>> + tristate
>> + depends on ACPI && I2C
>
> Can we leave
>
> depends on I2C
>
> line untouched?
Sure, I'll change that for v3.
Regards,
Hans
