On Thu, Jun 29, 2023 at 07:18:29PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thu, Jun 29, 2023 at 03:26:48PM +0300, Sakari Ailus wrote: > > Select V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API for all sensor drivers. This > > also adds the options to drivers that don't specifically need them, these > > are still seldom used drivers using old APIs. The upside is that these > > should now all compile --- many drivers have had missing dependencies. > > > > The "menu" is replaced by selectable "menuconfig" to select the needed > > V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API options. > > > > Also select MEDIA_CONTROLLER which VIDEO_V4L2_SUBDEV_API effectively > > depends on. > > > > Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > since v1: > > > > - Select MEDIA_CONTROLLER, don't depend on it. > > > > drivers/media/i2c/Kconfig | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 815c83135021c..c7ffaa79abeb9 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -25,8 +25,15 @@ config VIDEO_IR_I2C > > # V4L2 I2C drivers that are related with Camera support > > # > > > > -menu "Camera sensor devices" > > - visible if MEDIA_CAMERA_SUPPORT > > +menuconfig VIDEO_CAMERA_SENSOR > > + bool "Camera sensor devices" > > + depends on MEDIA_CAMERA_SUPPORT > > + select MEDIA_CONTROLLER > > + select V4L2_FWNODE > > + select VIDEO_V4L2_SUBDEV_API > > + default y > > + > > +if VIDEO_CAMERA_SENSOR > > Shouldn't you then remove the MEDIA_CONTROLLER, V4L2_FWNODE and > VIDEO_V4L2_SUBDEV_API selection from individual drivers' Kconfig entries > ? I've read your reply to Hans in v1. I'm fine doing it in a separate patch, but could it be bundled in the same series ? > > config VIDEO_APTINA_PLL > > tristate > > @@ -810,7 +817,7 @@ config VIDEO_ST_VGXY61 > > source "drivers/media/i2c/ccs/Kconfig" > > source "drivers/media/i2c/et8ek8/Kconfig" > > > > -endmenu > > +endif > > > > menu "Lens drivers" > > visible if MEDIA_CAMERA_SUPPORT -- Regards, Laurent Pinchart
