Hi, On 6/29/23 12:22, Sakari Ailus wrote: > Hi Hans, > > On Thu, Jun 29, 2023 at 12:11:01PM +0200, Hans de Goede wrote: >> Hi Sakari, >> >> On 6/29/23 10:11, Sakari Ailus wrote: >>> Select V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API for all sensor drivers. This >>> also adds the options to drivers that don't specifically need them, these >>> are still seldom used drivers using old APIs. The upside is that these >>> should now all compile --- many drivers have had missing dependencies. >>> >>> The "menu" is replaced by selectable "menuconfig" to select the needed >>> V4L2_FWNODE and VIDEO_V4L2_SUBDEV_API options. >>> >>> Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx> >>> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >> >> Thank you for working on this. This looks good to me, but shouldn't >> all the existing sensor Kconfig bits then have their depends on >> MEDIA_CAMERA_SUPPORT / MEDIA_CONTROLLER and select V4L2_FWNODE / VIDEO_V4L2_SUBDEV_API >> bits dropped ? > > Yes. I thought of doing that in a separate patch while this one could be > backported independently of any added sensor drivers. Ok, doing this in a follow up patch sounds good. > I forgot MEDIA_CONTROLLER now can be selected, it's not something to depend > on anymore. Ack. Regards, Hans
