On Tue, Jun 27, 2023 at 07:56:39PM +0200, Hans de Goede wrote: > Move all the code implementing cio2_bridge_init() into a new shared > intel-cio2-bridge.ko, so that it can be reused by the atomisp driver > (and maybe also by the future IPU6 CSI2 driver). > > Note this just moves a bunch of stuff around prefixes some symbols / > defines with intel_ / INTEL_ no functional changes. ... > +EXPORT_SYMBOL(intel_cio2_bridge_init); Why not GPL? Perhaps namespace? ... Seems to me that name CIO2 in AtomISP case sounds a bit weird. Maybe ipu/isp should be used instead? -- With Best Regards, Andy Shevchenko