On 25/06/2023 10:47, G.N. Zhou wrote: > Hi Krzysztof Kozlowski, > >> -----Original Message----- >> From: G.N. Zhou (OSS) >> Sent: 2023年6月25日 16:28 >> To: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; G.N. Zhou (OSS) >> <guoniu.zhou@xxxxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx; dl-linux-imx >> <linux-imx@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx >> Cc: laurent.pinchart@xxxxxxxxxxxxxxxx; mchehab@xxxxxxxxxx; >> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; >> Xavier Roumegue (OSS) <xavier.roumegue@xxxxxxxxxxx>; >> kernel@xxxxxxxxxxxxxx; jacopo.mondi@xxxxxxxxxxxxxxxx; >> sakari.ailus@xxxxxxxxxxxxxxx >> Subject: RE: [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: i.MX93 support >> >> Hi Krzysztof Kozlowski, >> >> Got it, will update. Thanks for your quick reviewing. >> >>> -----Original Message----- >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>> Sent: 2023年6月25日 16:22 >>> To: G.N. Zhou (OSS) <guoniu.zhou@xxxxxxxxxxx>; >>> linux-media@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; >>> devicetree@xxxxxxxxxxxxxxx >>> Cc: laurent.pinchart@xxxxxxxxxxxxxxxx; mchehab@xxxxxxxxxx; >>> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; >>> robh+conor+dt@xxxxxxxxxx; >>> Xavier Roumegue (OSS) <xavier.roumegue@xxxxxxxxxxx>; >>> kernel@xxxxxxxxxxxxxx; jacopo.mondi@xxxxxxxxxxxxxxxx; >>> sakari.ailus@xxxxxxxxxxxxxxx >>> Subject: Re: [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: >>> i.MX93 support >>> >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using the >> 'Report this email' >>> button >>> >>> >>> On 25/06/2023 10:09, guoniu.zhou@xxxxxxxxxxx wrote: >>>> From: "Guoniu.zhou" <guoniu.zhou@xxxxxxx> >>>> >>>> Add i.MX93 support since it reuse ISI which used in i.MX8M family. >>>> >>>> Signed-off-by: Guoniu.zhou <guoniu.zhou@xxxxxxx> >>> >>> Subject: Drop duplicated "media:" >>> >>>> --- >>>> Documentation/devicetree/bindings/media/nxp,imx-isi.yaml | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml >>>> b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml >>>> index 1ce9440bde32..ddad1d8778f3 100644 >>>> --- a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml >>>> +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml >>>> @@ -21,6 +21,7 @@ properties: >>>> enum: >>>> - fsl,imx8mn-isi >>>> - fsl,imx8mp-isi >>>> + - fsl,imx93-isi >>> >>> Imx93 is a family of devices, not specific device, so I hope you >>> understand that it is a bit against the recommendation of specific >>> compatibles and you guarantee that all devices within family will be identical. > > I'm litter confused about this since iMX93 is a specific device and belong to iMX9 family. Could you help to provide more details? What's confusing exactly? Open the website of NXP - it clearly says "i.MX 93 Applications Processor Family", so what do you mean by "specific device"? It's not. Open the datasheet. I already listed several differences between different imx93 SoCs. Basically - there is no such thing as imx93 SoC. There is imx9355 (or imx935x), imx933x etc. Why I need to provide more details about NXP SoCs? Aren't you from NXP? Best regards, Krzysztof
