Hi Laurent, On Tue, May 30, 2023 at 09:11:53AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thu, May 25, 2023 at 12:16:00PM +0300, Sakari Ailus wrote: > > This patch re-arranges internal V4L2 async lists for preparation of > > supporting multiple connections per sub-device as well as cleaning up used > > lists. > > > > The list of unbound V4L2 sub-devices is maintained for the purpose of > > listing those sub-devices only, not for their binding status. Also, the > > V4L2 async connections have a single list entry in the notifier's list, be > > that either waiting or done lists, while the notifier's asc_list is > > removed. > > Please use the imperative style in commit messages. To me it's unclear > if "is" here refers to the status before or after this patch. I need a > clear description of what you're doing in order to check if the code > matches the intent. Guessing the intent from the code makes review more > difficult and less useful. I'll reword this as: The list of unbound V4L2 sub-devices shall be maintained for the purpose of listing those sub-devices only, not for their bindin status. Also, the V4L2 async connections now have, instead of two list entries, a single list entry in the notifier's list, be that either waiting or done lists, while the notifier's asc_list is removed. -- Kind regards, Sakari Ailus
