Re: [PATCH v2 6/6] platform/x86: int3472: discrete: Log a warning if the pin-numbers don't match

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Jun 16, 2023 at 8:21 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> The INT3472 discrete code assumes that the ACPI GPIO resources are
> in the same order as the pin-info _DSM entries.
>
> The returned pin-info includes the pin-number in bits 15-8. Add a check
> that this matches with the ACPI GPIO resource pin-number in case
> the assumption is not true with some ACPI tables.

...

> +       pin = FIELD_GET(INT3472_GPIO_DSM_PIN, obj->integer.value);

I believe the definition should be in this patch which sounds to me
more logical.




--
With Best Regards,
Andy Shevchenko