Hi,
On 6/15/23 16:43, Andy Shevchenko wrote:
> On Thu, Jun 15, 2023 at 04:13:48PM +0200, Hans de Goede wrote:
>> Read and log sensor revision during probe.
>>
>> Since this means that the driver will now already log a message on
>> successful probe drop the "ov2680 init correctly" log message.
>
> ...
>
>> - ret = cci_read(sensor->regmap, OV2680_REG_CHIP_ID, &chip_id, NULL);
>> + cci_read(sensor->regmap, OV2680_REG_CHIP_ID, &chip_id, &ret);
>> + cci_read(sensor->regmap, OV2680_REG_SC_CMMN_SUB_ID, &rev, &ret);
>> if (ret < 0) {
>> dev_err(sensor->dev, "failed to read chip id\n");
>> return -ENODEV;
>
> Even in the original code I don't see justification why the error code should
> be shadowed.
Ack, I've squashed a fix for this into this patch (since it is already
making significant changes to ov2680_check_id() anways),
Regards,
Hans
