On 25/05/2023 09:31, Jack Zhu wrote:
Add basic platform driver for StarFive Camera Subsystem.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
Signed-off-by: Jack Zhu <jack.zhu@xxxxxxxxxxxxxxxx>
One thing here is the patch title and hence commit message.
"media: starfive:" doesn't really tell you this is a camera versus say a
encoder/decoder.
I see you've used the name "camss" for your driver, which I think is a
perfectly good and logical choice - however if you started to make
commits along the lines of "media: camss" that would conflict with the
qcom camss.
How about for starfive and qcom by the way, we do what Laurent did in
commit 3e8537b4c15172bfe1b285c3155ed5c37d523cd3
Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Date: Wed Dec 21 10:33:39 2022 +0100
media: ti: omap3isp: Use media_pipeline_for_each_entity()
i.e. future StarFive commits for camera would be "media: starfive:
camss" and similarly for Qualcomm "media: qualcomm: camss"
The point being the commit title namespace should be instructive and
specific re: 3e8537b4c15172bfe1b285c3155ed5c37d523cd3
---
bod
