On Wed, Jun 14, 2023 at 11:49 PM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > On Wed, Jun 14, 2023 at 09:23:39PM +0200, Hans de Goede wrote: ... > > +config V4L2_CCI > > + tristate > > + depends on I2C > > This won't do anything if the dependent driver will select V4L2_CCI, will > it? Actually it will. It may warn the user about missing dependency on the `make *config` stage. See, for example, this: https://lore.kernel.org/lkml/1f6c4559-ee48-ca67-8ff1-f7f9d330bc12@xxxxxxx/. > I'd let the sensor driver depend on I2C instead. CCI is also supported > on I3C, for instance. > > + select REGMAP_I2C > > This is a good question. > > How about adding V4L2_CCI_I2C that would select REGMAP_I2C? -- With Best Regards, Andy Shevchenko
