On Wed, Jun 14, 2023 at 10:24 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Use the new comon CCI register access helpers to replace the private > register access helpers in the ov5693 driver. ... > struct ov5693_device { > struct i2c_client *client; > struct device *dev; > + struct regmap *regmap; I forgot what the conclusion was regarding this. Now we have a client (which embeds the struct device), struct device pointer (is it the same device?), and now regmap, associated with (yet another?) struct device. > } ctrls; > }; -- With Best Regards, Andy Shevchenko