Hi Laurent, On Tue, May 30, 2023 at 09:01:15AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Thu, May 25, 2023 at 12:15:59PM +0300, Sakari Ailus wrote: > > The connections are checked for duplicates already when the notifier is > > registered. This is effectively a sanity check for driver (and possibly > > obscure firmware) bugs. Don't do this when adding the connection. > > Isn't it better to have this sanity check when the connection is added, > instead of later when the notifier is registered ? The latter is more > difficult to debug. If you want to avoid duplicate checks, could we drop > the one at notifier registration time ? I've never seen or heard this check failing. I'm therefore not very concerned keeping it as easy to debug as possible, instead I prefer simpler implementation. Checking at the registration time is still necessary as the same match could have been added to another notifier while this one was being set up. -- Kind regards, Sakari Ailus
