Hi Laurent, On Tue, May 30, 2023 at 08:08:48AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thu, May 25, 2023 at 12:15:56PM +0300, Sakari Ailus wrote: > > V4L2 async sub-device matching originally used the device nodes only. > > Endpoint nodes were taken into use instead as using the device nodes was > > problematic for it was in some cases ambiguous which link might have been > > in question. > > > > There is however no need to use endpoint nodes on both sides, as the async > > sub-device's fwnode can always be trivially obtained using > > fwnode_graph_get_remote_endpoint() when needed while what counts is > > whether or not the link is between two device nodes, i.e. the device nodes > > match. > > > > This will briefly break the adv748x driver but it will be fixed later in > > the set, by patch "media: adv748x: Return to endpoint matching". > > I'm afraid I don't like this. This series is complex and has a high risk > of causing tricky issues. I would like to be able to bisect the changes. As we discussed separately, this has been tested on both rcar-vin + adv748x and i.MX6, I'm not overly concerned of this. -- Kind regards, Sakari Ailus
