On Mon, Jun 12, 2023 at 05:31:51PM +0100, Vincenzo Frascino wrote:
> Hi Demi,
>
> On 6/10/23 21:40, Demi Marie Obenour wrote:
> > Some drivers already defined these, and they will be used by sscanf()
> > for overflow checks later. Also add SSIZE_MIN to limits.h, which will
> > also be needed later.
> >
> > Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
> > ---
> > .../media/atomisp/pci/hive_isp_css_include/platform_support.h | 1 -
> > include/linux/limits.h | 1 +
> > include/linux/mfd/wl1273-core.h | 3 ---
> > include/vdso/limits.h | 3 +++
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> >
> ...
>
> > diff --git a/include/vdso/limits.h b/include/vdso/limits.h
> > index 0197888ad0e00b2f853d3f25ffa764f61cca7385..0cad0a2490e5efc194d874025eb3e3b846a5c7b4 100644
> > --- a/include/vdso/limits.h
> > +++ b/include/vdso/limits.h
> > @@ -2,6 +2,9 @@
> > #ifndef __VDSO_LIMITS_H
> > #define __VDSO_LIMITS_H
> >
> > +#define UCHAR_MAX ((unsigned char)~0U)
> > +#define SCHAR_MAX ((signed char)(UCHAR_MAX >> 1))
> > +#define SCHAR_MIN ((signed char)(-SCHAR_MAX - 1))
>
> Are you planning to use those definitions in the vDSO library?
Nope. They were added here for consistency with the other *_{MIN,MAX}
defines.
> If not can you please define them in linux/limits.h, the vdso headers contain
> only what is necessary for the vDSO library.
Will fix in the next version.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab
Attachment:
signature.asc
Description: PGP signature
