On Thu, Jun 8, 2023 at 11:33 AM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > On Wed, Jun 07, 2023 at 11:07:28PM +0300, Andy Shevchenko wrote: > > On Wed, Jun 07, 2023 at 09:01:40PM +0200, Hans de Goede wrote: > > > On 6/7/23 20:18, Laurent Pinchart wrote: > > > > On Tue, Jun 06, 2023 at 06:58:06PM +0200, Hans de Goede wrote: ... > > > if (regs[i].delay_us) > > > fsleep(regs[i].delay_us); > > > > > > is copied from the implementation of regmap_multi_reg_write() > > > > Reading this I'm wondering if we can actually implement a regmap-cci inside > > drivers/base/regmap and use it. It might be that this is impossible, but can > > save us from repeating existing code I think. > > I very much prefer this set over trying to bury equivalent functionality > in regmap. CCI is quite unlike what regmap is intended for, due to > its variable width registers and that CCI isn't a bus itself (but on top of > the bus specification itself). Oh, okay, no objections! -- With Best Regards, Andy Shevchenko
