On Tue, Jun 6, 2023 at 2:26 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Tue, Jun 6, 2023 at 12:23 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > On 5/31/23 19:56, Andy Shevchenko wrote: ... > > Ack, I've squashed a fix for this into this patch while merging it into > > my review-hans branch. > > Now you have two different checks for the same, I would suggest that > you switch to check clk->cl in the skl_int3472_enable_clk() > as it's done in the skl_int3472_register_dsm_clock() instead of GPIO. > Other way around is also possible but it seems to me that checking for > clock existence has better guarantees than just checking for GPIO > availability. That said it might make sense to also introduce struct ... *clk = &int3472->clock; in skl_int3472_register_dsm_clock() so the above mentioned checks will be the same and actually code in the latter will look neater (?). -- With Best Regards, Andy Shevchenko
