sh_css_sp_group structure was managed by #ifdef ISP2401. The configuration structure was also determined in compile time which means we have to compile the kernel code twice for each ISP2400 and ISP2401. In order to determine the ISP types in runtime, the configuration structure needs to be unified. It allows can be used to configure both types of ISP. Since the length of the sh_css_sp_group for ISP2400 and ISP2401 is different, before submitting the configuration to ISP, the data has to be carefully put the necessary part to a buffer and then submitted to the ISP. Kate Hsuan (3): media: atomisp: sh_css_internal: Unifying sh_css_sp_group to remove #ifdef ISP2401 atomisp: sh_css_params: write the sp_group config according to the ISP model media: atomisp: ia_css_debug: remove unused codes .../runtime/debug/interface/ia_css_debug.h | 6 -- .../pci/runtime/debug/src/ia_css_debug.c | 76 +------------------ .../media/atomisp/pci/sh_css_internal.h | 35 +++------ .../staging/media/atomisp/pci/sh_css_params.c | 37 ++++++++- 4 files changed, 48 insertions(+), 106 deletions(-) -- 2.40.1