[PATCH 00/16] Use modaliases to load I2C modules - please review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi everybody,

Here's a bunch of patches (on top of staging/v2.6.37) that remove the
module_name argument to the v4l2_i2c_new_subdev* functions.

The module name is used by those functions to load the module corresponding
to the I2C sub-device being instanciated. As the I2C modules now support
modalias (and have been for quite some time), the module name isn't necessary
anymore.

The first patch adds the ability to load I2C modules based on modaliases when
the module name passed to the v4l_i2c_new_subdev* functions is NULL. This is
never the case with the in-tree drivers, so there shouldn't be any regression.

The 14 next patches modify all drivers that call those functions to pass a NULL
module name. Patch 2/16 touches all the drivers that hardcode the module name
directly when calling the function, and the remaining 13 patches do the same
for driver that fetch the module name from platform data or from other sources
(such as static tables). I've checked all I2C modules used by the drivers
modified in those patches to make sure they have a proper module devices table.

The last patch finally removes the module_name argument, as all callers now
pass a NULL value.

The code has obviously not been tested, as I lack the necessary hardware. I've
tested the V4L2 core changes with the OMAP3 ISP driver. All x86 drivers have
been compile-tested.

Laurent Pinchart (16):
  v4l: Load I2C modules based on modalias
  v4l: Remove hardcoded module names passed to v4l2_i2c_new_subdev*
  go7007: Add MODULE_DEVICE_TABLE to the go7007 I2C modules
  go7007: Fix the TW2804 I2C type name
  go7007: Don't use module names to load I2C modules
  zoran: Don't use module names to load I2C modules
  pvrusb2: Don't use module names to load I2C modules
  sh_vou: Don't use module names to load I2C modules
  radio-si4713: Don't use module names to load I2C modules
  soc_camera: Don't use module names to load I2C modules
  vpfe_capture: Don't use module names to load I2C modules
  vpif_display: Don't use module names to load I2C modules
  vpif_capture: Don't use module names to load I2C modules
  ivtv: Don't use module names to load I2C modules
  cx18: Don't use module names to load I2C modules
  v4l: Remove module_name argument to the v4l2_i2c_new_subdev*
    functions

 arch/arm/mach-mx3/mach-pcm037.c               |    2 -
 arch/arm/mach-mx3/mx31moboard-marxbot.c       |    1 -
 arch/arm/mach-mx3/mx31moboard-smartbot.c      |    1 -
 arch/arm/mach-pxa/em-x270.c                   |    1 -
 arch/arm/mach-pxa/ezx.c                       |    2 -
 arch/arm/mach-pxa/mioa701.c                   |    1 -
 arch/arm/mach-pxa/pcm990-baseboard.c          |    2 -
 arch/sh/boards/mach-ap325rxa/setup.c          |    1 -
 arch/sh/boards/mach-ecovec24/setup.c          |    4 --
 arch/sh/boards/mach-kfr2r09/setup.c           |    1 -
 arch/sh/boards/mach-migor/setup.c             |    2 -
 arch/sh/boards/mach-se/7724/setup.c           |    1 -
 drivers/media/radio/radio-si4713.c            |    2 +-
 drivers/media/video/au0828/au0828-cards.c     |    4 +-
 drivers/media/video/bt8xx/bttv-cards.c        |   22 +++++-----
 drivers/media/video/cafe_ccic.c               |    2 +-
 drivers/media/video/cx18/cx18-i2c.c           |   22 ++---------
 drivers/media/video/cx231xx/cx231xx-cards.c   |    4 +-
 drivers/media/video/cx23885/cx23885-cards.c   |    2 +-
 drivers/media/video/cx23885/cx23885-video.c   |    4 +-
 drivers/media/video/cx88/cx88-cards.c         |    9 ++--
 drivers/media/video/cx88/cx88-video.c         |    7 +--
 drivers/media/video/davinci/vpfe_capture.c    |    1 -
 drivers/media/video/davinci/vpif_capture.c    |    1 -
 drivers/media/video/davinci/vpif_display.c    |    2 +-
 drivers/media/video/em28xx/em28xx-cards.c     |   18 ++++----
 drivers/media/video/fsl-viu.c                 |    2 +-
 drivers/media/video/ivtv/ivtv-i2c.c           |   50 +++++--------------------
 drivers/media/video/mxb.c                     |   12 +++---
 drivers/media/video/pvrusb2/pvrusb2-hdw.c     |   13 +-----
 drivers/media/video/saa7134/saa7134-cards.c   |    8 ++--
 drivers/media/video/saa7134/saa7134-core.c    |    4 +-
 drivers/media/video/sh_vou.c                  |    2 +-
 drivers/media/video/soc_camera.c              |    2 +-
 drivers/media/video/usbvision/usbvision-i2c.c |    6 +-
 drivers/media/video/v4l2-common.c             |   13 ++----
 drivers/media/video/vino.c                    |    4 +-
 drivers/media/video/zoran/zoran.h             |    2 -
 drivers/media/video/zoran/zoran_card.c        |   24 +----------
 drivers/staging/go7007/go7007-driver.c        |   43 +--------------------
 drivers/staging/go7007/go7007-usb.c           |    2 +-
 drivers/staging/go7007/wis-ov7640.c           |    1 +
 drivers/staging/go7007/wis-saa7113.c          |    1 +
 drivers/staging/go7007/wis-saa7115.c          |    1 +
 drivers/staging/go7007/wis-sony-tuner.c       |    1 +
 drivers/staging/go7007/wis-tw2804.c           |    1 +
 drivers/staging/go7007/wis-tw9903.c           |    1 +
 drivers/staging/go7007/wis-uda1342.c          |    1 +
 drivers/staging/tm6000/tm6000-cards.c         |    4 +-
 include/media/sh_vou.h                        |    1 -
 include/media/v4l2-common.h                   |   16 +++-----
 51 files changed, 100 insertions(+), 234 deletions(-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux