On 23-06-01, Sakari Ailus wrote: > Address these compiler warnings by initialising the m_best and p_best > values to 0 and 1 respectively (as latter is used as a divisor): > > drivers/media/i2c/tc358746.c: In function 'tc358746_find_pll_settings': > >> drivers/media/i2c/tc358746.c:817:13: warning: 'p_best' is used uninitialized > [-Wuninitialized] > 817 | u16 p_best, p; > | ^~~~~~ > >> drivers/media/i2c/tc358746.c:816:13: warning: 'm_best' is used uninitialized > [-Wuninitialized] > 816 | u16 m_best, mul; > | ^~~~~~ > > The warnings may well be a false positive but it is difficult for a > compiler to find out whether that truly is the case. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202305301627.fLT3Bkds-lkp@xxxxxxxxx/ > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > --- > since v1: > > - Note that this may be a false positive. > > drivers/media/i2c/tc358746.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c > index ec1a193ba161a..25fbce5cabdaa 100644 > --- a/drivers/media/i2c/tc358746.c > +++ b/drivers/media/i2c/tc358746.c > @@ -813,8 +813,8 @@ static unsigned long tc358746_find_pll_settings(struct tc358746 *tc358746, > u32 min_delta = 0xffffffff; > u16 prediv_max = 17; > u16 prediv_min = 1; > - u16 m_best, mul; > - u16 p_best, p; > + u16 m_best = 0, mul; > + u16 p_best = 1, p; > u8 postdiv; > > if (fout > 1000 * HZ_PER_MHZ) { > -- > 2.30.2 > >
