Hi Sakari, On 23-06-01, Sakari Ailus wrote: > On Thu, Jun 01, 2023 at 08:20:06AM +0000, Sakari Ailus wrote: > > Hi Marco, > > > > On Wed, May 31, 2023 at 10:18:10AM +0200, Marco Felsch wrote: > > > Hi Sakari, > > > > > > Hans already sent a patch a few months ago: > > > - https://lore.kernel.org/linux-media/15030a07-3615-fca0-1891-a234dc054b00@xxxxxxxxx/ > > > > > > It turned out that the compiler had a bug albeit the compiler listed in > > > 'Closes:' is already a gcc-12 and now the warning used is slightly > > > different. > > > > > > I'm not again the patch but we should point out that this patch is only > > > required to make the compiler happy. > > > > Ack, thanks. I'll drop this then. The condition isn't trivial for a > > compiler to figure out though, even I'm not quite sure this is the case for > > all parameter values. I don't want to complain here O:) and as I said we can pick the patch but we should mention that this is a patch for the compiler. > Hans's patch actually assigns p_best to 0 which isn't a best default value > for a divisor. You're right. Regards, Marco
