Hi Dave
On Tue, May 30, 2023 at 06:29:43PM +0100, Dave Stevenson wrote:
> Registers 0x0202 and 0x0203 are written via the control handler
> for V4L2_CID_EXPOSURE, so are not needed from the mode lists.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/imx258.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
> index aabd5c3e8af9..b695fd987b71 100644
> --- a/drivers/media/i2c/imx258.c
> +++ b/drivers/media/i2c/imx258.c
> @@ -237,8 +237,6 @@ static const struct imx258_reg mode_4208x3120_regs[] = {
> { 0x034E, 0x0C },
> { 0x034F, 0x30 },
> { 0x0350, 0x01 },
> - { 0x0202, 0x0C },
> - { 0x0203, 0x46 },
> { 0x0204, 0x00 },
> { 0x0205, 0x00 },
> { 0x020E, 0x01 },
> @@ -356,8 +354,6 @@ static const struct imx258_reg mode_2104_1560_regs[] = {
> { 0x034E, 0x06 },
> { 0x034F, 0x18 },
> { 0x0350, 0x01 },
> - { 0x0202, 0x06 },
> - { 0x0203, 0x2E },
> { 0x0204, 0x00 },
> { 0x0205, 0x00 },
> { 0x020E, 0x01 },
> @@ -475,8 +471,6 @@ static const struct imx258_reg mode_1048_780_regs[] = {
> { 0x034E, 0x03 },
> { 0x034F, 0x0C },
> { 0x0350, 0x01 },
> - { 0x0202, 0x03 },
> - { 0x0203, 0x42 },
> { 0x0204, 0x00 },
> { 0x0205, 0x00 },
> { 0x020E, 0x01 },
> --
> 2.25.1
>
