Hi,
On 5/30/23 13:51, Andy Shevchenko wrote:
> On Mon, May 29, 2023 at 9:13 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
>> On Mon, May 29, 2023 at 1:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> ...
>
>>> +static int ov2680_init_cfg(struct v4l2_subdev *sd,
>>> + struct v4l2_subdev_state *sd_state)
>>> +{
>>> + struct v4l2_subdev_format fmt = {
>>> + .which = sd_state ? V4L2_SUBDEV_FORMAT_TRY
>>> + : V4L2_SUBDEV_FORMAT_ACTIVE,
>>> + .format = {
>>> + .width = 800,
>>> + .height = 600,
>>
>>> + }
>>
>> I would keep a trailing comma here.
>>
>>> + };
>>> +
>>> + return ov2680_set_fmt(sd, sd_state, &fmt);
>>> +}
>
> This is not addressed in your branch.
Oops, sorry I've fixed this in my branch now and I've also changed
6/21 to make __ov2680_get_pad_crop() look like this:
static struct v4l2_rect *
__ov2680_get_pad_crop(struct ov2680_dev *sensor, struct v4l2_subdev_state *state,
unsigned int pad, enum v4l2_subdev_format_whence which)
{
if (which == V4L2_SUBDEV_FORMAT_TRY)
return v4l2_subdev_get_try_crop(&sensor->sd, state, pad);
return &sensor->mode.crop;
}
Regards,
Hans
