Hi Sakari,
Thank you for the patch.
On Thu, May 25, 2023 at 12:15:51PM +0300, Sakari Ailus wrote:
> The callers do pass a non-NULL asd to v4l2_async_nf_asd_valid() already.
> There's no need for the NULL check here.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/v4l2-core/v4l2-async.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
> index aef9a16e892ef..7c924faac4c10 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -552,9 +552,6 @@ static int v4l2_async_nf_asd_valid(struct v4l2_async_notifier *notifier,
> {
> struct device *dev = notifier_dev(notifier);
>
> - if (!asd)
> - return -EINVAL;
> -
> switch (asd->match_type) {
> case V4L2_ASYNC_MATCH_I2C:
> case V4L2_ASYNC_MATCH_FWNODE:
--
Regards,
Laurent Pinchart
