On Mon, May 29, 2023 at 1:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > Here is my next round of atomisp work. > > The atomisp wants some extra padding for processing in the data it receives > from the sensor. E.g. For 1600x1200 it wants to receive 1616x1216 from > the sensor. Currently the private sensor driver copies it uses give it > e.g. 1616x1216 and the ISP2 code then substracts 16 before reporting > the resolution to userspace. > > This patch series adds support for the v4l2 selections API and specifically > the crop target so that atomisp can request the extra padding from standard > v4l2 sensor drivers. This is implemented / tested with the atomisp_ov2680 > driver. > > Besides that there is the usual cleanups / prep work. > > With the padding solved, the last bit of private atomisp sensor API is > gone now. So we can start working on getting rid of its private sensor > driver copies. > > As mentioned in the updated TODO file the next step is to port > various improvements from the atomisp_ov2680 private sensor driver > to the generic ov2680 sensor driver (such as the selections support) > and then switch to the generic ov2680 sensor driver. For non-commented Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> If others will be addressed in the suggested way, feel free to add the tag as well. -- With Best Regards, Andy Shevchenko