On Sat, May 27, 2023 at 12:25 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 5/26/23 22:30, Andy Shevchenko wrote: > > On Thu, May 25, 2023 at 10:01 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: ... > > Besides that since we have a handle, wouldn't it be better to use > > acpi_handle_info() here? > > Yes since we are purely dealing with ACPI / fwnode stuff here using > that would make more sense. I'll switch to that. > > I also agree with all your other remarks and I'll fix them all up > (and test things again) before merging. > > Andy, may I add your Reviewed-by to this patch too after fixing > up all your remarks ? Sure, go ahead! -- With Best Regards, Andy Shevchenko