On Thu, May 25, 2023 at 10:01 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > Here is a new version of my v4l2-async sensor registration support > for atomisp. I have merged all the prep / cleanup patches which Andy > already gave his Reviewed-by for in my media-atomisp branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp > > This v2 series applies on top of that branch! > > This v2 series is the remainder (and core part) of > my previous 2 related patch-series: > > https://lore.kernel.org/linux-media/20230518153733.195306-1-hdegoede@xxxxxxxxxx/ > https://lore.kernel.org/linux-media/20230518153214.194976-1-hdegoede@xxxxxxxxxx/ > > The big change in this v2 is making atomisp_csi2_bridge_init() also > add the ACPI GPIO mappings to the sensors it finds / it is adding > fwnode graph endpoints for. Combined with making sensor drivers > check there is a fwnode graph endpoint (and return -EPROBE_DEFER if not) > before trying to get GPIOs so that the mappings are in place before > getting the GPIOs. > > Thank you Sakari for suggesting this nice solution. Indeed, it looks nicer! So far I looked into this series and for non-commented ones: Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Patch 1 Adds the v4l2-async sensor registration support > Patch 2-3 Convert the ov2680 and gc0310 drivers to this > Patch 4 Removes some now dead code > Patch 5 Moves the now fully standard / no custom atomisp API > gc0310 sensor driver to drivers/media/i2c > > Patches 1-4 only touch atomisp code and build on top of previous > work so I plan to merge these through my media-atomisp branch. > > Patch 5 also depends on all the others, so it should also > get merged through my media-atomisp branch. Sakari may I have > your Ack for this ? Alternatively we could delay the move to > the next kernel cycle and then it could be merged directly > into some other linux-media branch. Either way works for me. -- With Best Regards, Andy Shevchenko