Re: [GIT PATCHES FOR 2.6.37] Remove v4l2-i2c-drv.h and most of i2c-id.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Thu, 23 Sep 2010 08:14:43 +0200, Hans Verkuil wrote:
> Jean, I did a grep of who is still including i2c-id.h (excluding media drivers):
> 
> drivers/gpu/drm/nouveau/nouveau_i2c.h:#include <linux/i2c-id.h>
> drivers/gpu/drm/radeon/radeon_mode.h:#include <linux/i2c-id.h>
> drivers/gpu/drm/i915/intel_drv.h:#include <linux/i2c-id.h>
> drivers/gpu/drm/i915/intel_i2c.c:#include <linux/i2c-id.h>
> drivers/video/i810/i810.h:#include <linux/i2c-id.h>
> drivers/video/intelfb/intelfb_i2c.c:#include <linux/i2c-id.h>
> drivers/video/savage/savagefb.h:#include <linux/i2c-id.h>
> drivers/video/aty/radeon_i2c.c:#include <linux/i2c-id.h>
> drivers/i2c/busses/i2c-s3c2410.c:#include <linux/i2c-id.h>
> drivers/i2c/busses/i2c-pxa.c:#include <linux/i2c-id.h>
> drivers/i2c/busses/i2c-ibm_iic.c:#include <linux/i2c-id.h>

I additionally have drivers/i2c/busses/i2c-nuc900.c.

> AFAIK none of these actually need this include. It's probably a good idea for
> you to remove together with

Will do, thanks for suggesting.

> this obsolete I2C_HW_B_RIVA:
> 
> drivers/video/riva/rivafb-i2c.c:        chan->adapter.id                = I2C_HW_B_RIVA;

I'll have to wait for your cleanup to hit upstream before I can remove
that one.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux