On Wed, May 24, 2023 at 11:51:34AM +0800, bingbu.cao@xxxxxxxxx wrote:
> From: Bingbu Cao <bingbu.cao@xxxxxxxxx>
>
> On some platforms, the imaging clock should be controlled by evaluating
> specific clock device's _DSM method instead of setting gpio, so this
> change register clock if no gpio based clock and then use the _DSM method
> to enable and disable clock.
...
Add a comment here where you put the GUID in a human-readable format for easy
googling / searching for in the internet / documentation.
> +static const guid_t img_clk_guid =
> + GUID_INIT(0x82c0d13a, 0x78c5, 0x4244,
> + 0x9b, 0xb1, 0xeb, 0x8b, 0x53, 0x9a, 0x8d, 0x11);
...
With
struct acpi_device *adev = ...;
> + init.name = kasprintf(GFP_KERNEL, "%s-clk",
> + acpi_dev_name(int3472->adev));
This become a single line.
> + if (!init.name)
> + return -ENOMEM;
> +
> + int3472->clock.frequency = skl_int3472_get_clk_frequency(int3472);
> + int3472->clock.clk_hw.init = &init;
> + int3472->clock.clk = clk_register(&int3472->adev->dev,
And the above can be reused later in this function, like
int3472->clock.clk = clk_register(&adev->dev, &int3472->clock.clk_hw);
> + &int3472->clock.clk_hw);
> + if (IS_ERR(int3472->clock.clk)) {
> + ret = PTR_ERR(int3472->clock.clk);
> + goto out_free_init_name;
> + }
--
With Best Regards,
Andy Shevchenko
