Re: [PATCH] media: v4l2-subdev: Fix missing kerneldoc for client_caps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

On Thu, May 18, 2023 at 09:41:31AM +0100, Mauro Carvalho Chehab wrote:
> Em Tue, 18 Apr 2023 13:59:24 +0300
> Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> escreveu:
> 
> > Add missing kernel doc for the new 'client_caps' field in struct
> > v4l2_subdev_fh.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> > ---
> >  include/media/v4l2-subdev.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index cfd19e72d0fc..9d0a6a993fb0 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> > @@ -1119,6 +1119,7 @@ struct v4l2_subdev {
> >   * @vfh: pointer to &struct v4l2_fh
> >   * @state: pointer to &struct v4l2_subdev_state
> >   * @owner: module pointer to the owner of this file handle
> > + * @client_caps: bitmask of V4L2_SUBDEV_CLIENT_CAP_*
> 
> Did you actually check this patch? Adding an asterisk at the end
> should hit a Sphinx warning, as asterisk is the italic markup.
> So, it seems to me that this patch is actually replacing one warning
> by another one!

I don't get a warning with this patch. Also the documentation is rendered
correctly. Which sphinx version do you have?

$ sphinx-build --version
sphinx-build 3.4.3

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux