On Thu, May 18, 2023 at 6:37 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > The info in the MRFLD_PORT_NUM define is duplicate with > the ATOMISP_CAMERA_NR_PORTS define. Drop MRFLD_PORT_NUM. JFYI: Since the long term plan of mine is to eventually do something useful on Intel MID platforms, I would like to keep the Merrifield (Tangier) / Moorefield (Annidale) support in this driver. That said, this patch doesn't do any harm to that, so I'm happy. ... > - u8 sensor_lanes[MRFLD_PORT_NUM] = { 0 }; > + u8 sensor_lanes[ATOMISP_CAMERA_NR_PORTS] = { 0 }; You may drop 0 as well. -- With Best Regards, Andy Shevchenko