Hi Dmitry, On Wed, May 17, 2023 at 12:12:05PM -0700, Dmitry Torokhov wrote: > On Wed, May 17, 2023 at 09:21:00PM +0300, Sakari Ailus wrote: > > Hi Arnd, > > > > On Mon, Jan 30, 2023 at 02:09:47PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > > > The gpio usage in the function is fairly straightforward, > > > but the normal gpiod_get() interface cannot be used here > > > since the gpio is referenced by a child node of the device. > > > > > > Using devm_fwnode_gpiod_get_index() is the best alternative > > > here. > > > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > > > I've picked > > <URL:https://patchwork.linuxtv.org/project/linux-media/patch/20230130131003.668888-1-arnd@xxxxxxxxxx/> > > instead. I hope that's fine. Also cc Dmitry. > > What do you mean "instead"? This is the exact patch that started this > thread, and it is broken (uses wrong name of the GPIO and wrong polarity). > > I'd much rather you picked up > https://lore.kernel.org/all/Y92VLGLQJZ%2FUDRx1@xxxxxxxxxx/ > > Thanks. Ah, the URL in my e-mail was wrong. I have <URL:https://patchwork.linuxtv.org/project/linux-media/patch/Y92VLGLQJZ/UDRx1@xxxxxxxxxx/>, i.e. the same patch. -- Regards, Sakari Ailus