On Sat, May 13, 2023 at 3:32 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Since there only is one /dev/video# node now (no more continuous mode),
> there are now no longer separate main capture + view-finder pipes.
>
> We are now always on the main pipe, so atomisp_is_vf_pipe() should
> always return false now. Drop any checks using it, replacing them
> with the code-path for a false return.
...
> + if (arg->per_frame_setting) {
> /*
> * Per-frame setting enabled, we allocate a new parameter
> * buffer to cache the parameters and only when frame buffers
...
> - if (!(arg->per_frame_setting && !atomisp_is_vf_pipe(pipe))) {
> + if (!arg->per_frame_setting) {
I'm wondering if we can make the conditional positive as in the above
chunk, so the below will go to the else branch. It might be that both
of them can be united (haven't checked the full context though).
> /* indicate to CSS that we have parameters to be updated */
> asd->params.css_update_params_needed = true;
> } else {
--
With Best Regards,
Andy Shevchenko
